Skip to content

SONARJAVA-5874 Fix bug with varargs on S1319 #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabrielFleischer merged 1 commit into from
Nov 24, 2025
Merged

SONARJAVA-5874 Fix bug with varargs on S1319 #5361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ks-test-sources/default/src/main/java/checks/CollectionImplementationReferencedCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ public void foo18(LinkedList<Integer> list){ // Noncompliant
private void foo19(List<Integer> l){
return;
}

public void foo20(LinkedList<String> list) { // Noncompliant
String.format("", 0, 0);
}
private LinkedList<Integer> getList() {
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion java-checks/src/main/java/org/sonar/java/checks/CollectionImplementationReferencedCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ public void visitMethodInvocation(MethodInvocationTree tree) {
return;
}
var paramTypes = methodSymbol.parameterTypes();
for (int i = 0; i < arguments.size(); i++) {
for (int i = 0; i < arguments.size() && i < paramTypes.size(); i++) {
processorArgument(arguments.get(i), paramTypes.get(i));
}
}
Expand Down
Loading