Skip to content

SONARJAVA java:S1166 (either log or rethrow exception) should not raise an issue when using unnamed variables (conflict with rule java:S7467) #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jmanom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SONARJAVA java:S1166 (either log or rethrow exception) should not raise an issue when using unnamed variables (conflict with rule java:S7467) #5383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ...-checks-test-sources/default/src/main/java/checks/CatchUsesExceptionWithContextCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,33 @@ private void f(Exception x) {
System.out.println("" + e);
}
}

// Unnamed exception variables
try {
} catch (Exception _) { // Compliant
}

try {
} catch (Exception _) { // Compliant
try {
} catch (Exception _) { // Compliant
}
}

try {
} catch (Exception _) { // Compliant
try {
} catch (Exception z) { // Noncompliant {{Either log or rethrow this exception.}}
}
}

try {
} catch (Exception e) { // Compliant
System.out.println(e);
try {
} catch (Exception _) { // Compliant
}
}
}

private void g() {
Expand Down
7 changes: 6 additions & 1 deletion java-checks/src/main/java/org/sonar/java/checks/CatchUsesExceptionWithContextCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ public void visitCatch(CatchTree tree) {
Symbol exception = tree.parameter().symbol();
usageStatusStack.addFirst(new UsageStatus(exception.usages()));
super.visitCatch(tree);
if (usageStatusStack.pop().isInvalid() && !exception.isUnknown()) {
if (usageStatusStack.pop().isInvalid() && !exception.isUnknown()
&& !isExceptionVariableUnnamed(tree.parameter())) {
context.reportIssue(this, tree.parameter(), "Either log or rethrow this exception.");
}
}
Expand Down Expand Up @@ -207,6 +208,10 @@ public void visitMemberSelectExpression(MemberSelectExpressionTree tree) {

}

private boolean isExceptionVariableUnnamed(VariableTree parameter) {
return parameter.simpleName().isUnnamedVariable();
}

private boolean isExcludedType(Tree tree) {
if (tree.is(Kind.UNION_TYPE)) {
return ((UnionTypeTree) tree).typeAlternatives().stream().allMatch(this::isExcludedType);
Expand Down