Skip to content

SONARJAVA-5942 Fix CI: use Java 21 in plugin QA and bump SpotBugs to 4.9.8.2 #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasz-tylenda-sonarsource merged 4 commits into from
Jan 7, 2026
Merged

SONARJAVA-5942 Fix CI: use Java 21 in plugin QA and bump SpotBugs to 4.9.8.2 #5384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
176d0e5
Fix CI: use Java 21 in plugin QA and bump SpotBugs to 4.9.8.2
tomasz-tylenda-sonarsource Jan 6, 2026
a42114c
Remove spotbugs version in Java Code
tomasz-tylenda-sonarsource Jan 7, 2026
43de013
Run Plugin QA LATEST_RELEASE with Java 17 and 21
tomasz-tylenda-sonarsource Jan 7, 2026
8d0e987
simplify
tomasz-tylenda-sonarsource Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ jobs:
- uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2.0
with:
version: 2025.7.12
- name: Select Java 17
run: mise use java@17
- name: Select Java 21
run: mise use java@21
Copy link
Contributor

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a little early to switch all plugin QA to Java 21 but at least that's work we won't have to do for the LTA

Copy link
Contributor Author

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the config, so that we keep running LATEST_RELEASE with Java 17.

- name: Configure Maven
uses: SonarSource/ci-github-actions/config-maven@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion its/plugin/projects/spotbugs-external-report/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>4.5.3.0</version>
<version>4.9.8.2</version>
<configuration>
<plugins>
<plugin>
Expand Down
2 changes: 1 addition & 1 deletion its/plugin/tests/src/test/java/com/sonar/it/java/suite/ExternalReportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public void pmd() {
public void spotbugs() {
MavenBuild build = TestUtils.createMavenBuild().setPom(TestUtils.projectPom("spotbugs-external-report"))
.setProperty("sonar.java.spotbugs.reportPaths", "target" + File.separator + "spotbugsXml.xml")
.setGoals("clean package com.github.spotbugs:spotbugs-maven-plugin:4.5.3.0:spotbugs", "sonar:sonar");
.setGoals("clean package com.github.spotbugs:spotbugs-maven-plugin:4.9.8.2:spotbugs", "sonar:sonar");
Copy link
Contributor

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify the version of the plugin here? My understanding is that because the plugin is versioned in the pom.xml of the project, this is redundant. Or am I missing something?

Copy link
Contributor Author

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maven expert. I dropped the version and the CI passes, so I guess we can do this.

orchestrator.executeBuild(build);

String projectKey = "org.sonarsource.it.projects:spotbugs-external-report";
Expand Down
2 changes: 1 addition & 1 deletion mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[tools]
java = ["24", "17"]
java = ["24", "21", "17"]
maven = "3.9"
Loading