SONARJAVA-5946 Use develocity in GHA build #5386
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
.github/workflows/build.yml
Outdated
| artifactory-reader-role: private-reader | ||
| artifactory-deployer-role: qa-deployer | ||
| use-develocity: true | ||
| develocity-url: https://develocity-public.sonar.build/ |
There was a problem hiding this comment.
I think, it makes sense to use workflow variable here and in following usages. What do you think?
There was a problem hiding this comment.
Do you mean env block at the top-level? I just added it. I also thought of using & and * to repeat the entire config-maven step, but I'm not sure if I like this yaml feature.
There was a problem hiding this comment.
I honestly prefer to avoid & and * features in most places. I feel like they hide the configuration and makes reading the pipeline harder.
If there is really a big duplication, it's ok.
There was a problem hiding this comment.
Yep, I meant exactly this :) I think now it looks good, we don't need to add another generalization.
There was a problem hiding this comment.
Oh, didn't know about '& and *' feature, looks really ugly. Agree with Gabriel.
|
GabrielFleischer
left a comment
GabrielFleischer
left a comment
There was a problem hiding this comment.
I wonder if it's possible to use build-maven instead of config-maven then build for the custom-rules-license-check job.
But I didn't find an easy way so I won't complain.
LGTM
3 participants
test-analyze, it is a long step, which can block the pipeline.