Skip to content

SONARJAVA-6012 Migrate ITs to Java 21 #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomasz-tylenda-sonarsource merged 6 commits into from
Jan 28, 2026
Merged

SONARJAVA-6012 Migrate ITs to Java 21 #5407

tomasz-tylenda-sonarsource merged 6 commits into from
Jan 28, 2026
+48 −24

Conversation

@tomasz-tylenda-sonarsource
Copy link
Contributor

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource commented Jan 28, 2026 •
edited
Loading

  • We need to use 21 for compatibility with the new SQS.
  • Some ruling tests changed, due to deprecation of java SDK members.
  • Autoscan results changed on rules related to Java 21.
  • Guava (the old version we test on) requires complilation with Java 17, so we extract it, and test with Java 17 and SQ 2025.4.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fix its failure SONARJAVA-6012 Fix its failure Jan 28, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Jan 28, 2026 •
edited by atlassian bot
Loading

SONARJAVA-6012

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title SONARJAVA-6012 Fix its failure SONARJAVA-6012 Fix ITs failure Jan 28, 2026
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title SONARJAVA-6012 Fix ITs failure SONARJAVA-6012 Migrate ruling ITs to Java 21 to fix the build Jan 28, 2026
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title SONARJAVA-6012 Migrate ruling ITs to Java 21 to fix the build SONARJAVA-6012 Migrate ruling ITs to Java 21 Jan 28, 2026
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title SONARJAVA-6012 Migrate ruling ITs to Java 21 SONARJAVA-6012 Migrate ITs to Java 21 Jan 28, 2026
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource marked this pull request as ready for review January 28, 2026 11:26
@sonarqube-next
Copy link

sonarqube-next bot commented Jan 28, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

asya-vorobeva
asya-vorobeva approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@asya-vorobeva asya-vorobeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for interrupting, I've checked, looks ok.

@tomasz-tylenda-sonarsource
Copy link
Contributor Author

tomasz-tylenda-sonarsource commented Jan 28, 2026

Sorry for interrupting, I've checked, looks ok.

Let's wait for Dorian's review. We discussed this PR offline.

dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit fbc6581 into master Jan 28, 2026
19 checks passed
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource deleted the tt/java21-its branch January 28, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource approved these changes

@asya-vorobeva asya-vorobeva asya-vorobeva approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomasz-tylenda-sonarsource @dorian-burihabwa-sonarsource @asya-vorobeva