SONARKT-644 Fix FP in S6311 when no Dispatcher is used explicitly

egon-okerman-sonarsource · web-flow · commit 45289f45f908 · 2025-04-03T12:14:14.000Z
diff --git a/kotlin-checks-test-sources/src/main/kotlin/checks/SuspendingFunCallerDispatcherCheckSample.kt b/kotlin-checks-test-sources/src/main/kotlin/checks/SuspendingFunCallerDispatcherCheckSample.kt
@@ -41,6 +41,10 @@ class SuspendingFunCallerDispatcherCheckSample(val injectable: CoroutineDispatch
             launch(Dispatchers.IO) { // Compliant
                 Thread.sleep(500L)
             }
+
+            async { // Compliant, no Dispatcher is used explicitly
+                complex()
+            }
         }
     }
 
diff --git a/sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/SuspendingFunCallerDispatcherCheck.kt b/sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/SuspendingFunCallerDispatcherCheck.kt
@@ -43,6 +43,7 @@ class SuspendingFunCallerDispatcherCheck : CallAbstractCheck() {
             && callExpressions.all {
                 (it.resolveToCall()?.singleFunctionCallOrNull()?.partiallyAppliedSymbol?.signature?.symbol as? KaNamedFunctionSymbol)?.isSuspend == true
             }
+            && arguments.size == 2
         ) {
             val argExpr = arguments.elementAt(0)
             kotlinFileContext.reportIssue(argExpr, "Remove this dispatcher. It is pointless when used with only suspending functions.")

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,10 @@ class SuspendingFunCallerDispatcherCheckSample(val injectable: CoroutineDispatch`
`41`	`41`	`launch(Dispatchers.IO) { // Compliant`
`42`	`42`	`Thread.sleep(500L)`
`43`	`43`	`}`
	`44`	`+`
	`45`	`+ async { // Compliant, no Dispatcher is used explicitly`
	`46`	`+ complex()`
	`47`	`+ }`
`44`	`48`	`}`
`45`	`49`	`}`
`46`	`50`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ class SuspendingFunCallerDispatcherCheck : CallAbstractCheck() {`
`43`	`43`	`&& callExpressions.all {`
`44`	`44`	`(it.resolveToCall()?.singleFunctionCallOrNull()?.partiallyAppliedSymbol?.signature?.symbol as? KaNamedFunctionSymbol)?.isSuspend == true`
`45`	`45`	`}`
	`46`	`+ && arguments.size == 2`
`46`	`47`	`) {`
`47`	`48`	`val argExpr = arguments.elementAt(0)`
`48`	`49`	`kotlinFileContext.reportIssue(argExpr, "Remove this dispatcher. It is pointless when used with only suspending functions.")`