Skip to content

Commit 9eadc7a

Browse files
authored
Fix quality flaw: Use "require", immutable list, remove unused import (#403)
1 parent 5be4aaf commit 9eadc7a

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/RedundantMethodsInDataClassesCheck.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ private fun checkIfExpressionHasParameter(
187187
first: KtExpression?,
188188
second: KtExpression?,
189189
klassParameters: List<KtParameter>,
190-
methodParameters: MutableList<KtParameter>,
190+
methodParameters: List<KtParameter>,
191191
map: MutableMap<KtParameter, Boolean>,
192192
) {
193193
val parameter = findParameter(first, klassParameters) ?: return

sonar-kotlin-plugin/src/main/java/org/sonarsource/kotlin/plugin/KotlinPlugin.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import org.sonarsource.kotlin.externalreport.detekt.DetektRulesDefinition
3232
import org.sonarsource.kotlin.externalreport.detekt.DetektSensor
3333
import org.sonarsource.kotlin.externalreport.ktlint.KtlintRulesDefinition
3434
import org.sonarsource.kotlin.externalreport.ktlint.KtlintSensor
35-
import org.sonarsource.kotlin.gradle.GRADLE_PROJECT_ROOT_PROPERTY
3635
import org.sonarsource.kotlin.gradle.KotlinGradleSensor
3736
import org.sonarsource.kotlin.surefire.KotlinResourcesLocator
3837
import org.sonarsource.kotlin.surefire.KotlinSurefireParser

sonar-kotlin-plugin/src/main/java/org/sonarsource/kotlin/plugin/linking/package-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@
1818
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
1919
*/
2020
@javax.annotation.ParametersAreNonnullByDefault
21-
package org.sonarsource.kotlin.api.frontend;
21+
package org.sonarsource.kotlin.plugin.linking;

sonar-kotlin-test-api/src/main/java/org/sonarsource/kotlin/testapi/DummyInputFile.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class DummyInputFile(val path: Path? = null) : InputFile {
7676
newRange(newPointer(startLine, startLineOffset), newPointer(endLine, endLineOffset))
7777

7878
override fun selectLine(line: Int): TextRange {
79-
if (line > lines.size) throw IllegalArgumentException("Line not in file")
79+
require(line <= lines.size) { "Line not in file" }
8080
return newRange(line, 0, line, lines[line - 1].length)
8181
}
8282

0 commit comments

Comments
 (0)