-
Notifications
You must be signed in to change notification settings - Fork 24
BUILD-7780: Use monthly cache for orchestrator #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
34f0654
to
0ead6ed
Compare
67a5e9a
to
955f164
Compare
f6d0959
to
f800aa2
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at https://cirrus-ci.com/task/5138860197281792
Seems that cache is always reuploaded because it contains plugin whose build number changes with every build:
Cache orchestrator has changed!
List of changes for cache folders (/tmp/cirrus-ci-build/orchestrator/LATEST_RELEASE/March):
created: cache/6ed2bf71b59fdbfdb2a7588213dddc61/sonar-kotlin-plugin-3.1.0.6960.jar
orchestrator cache size is 1014Mb.
Uploading cache orchestrator...
And this task lacs execution of clean-orchestrator-cache.sh
32eccf2
to
dc8699e
Compare
@julien-carsique-sonarsource AFAICS in addition to sonar-application you're trying to preserve at least one sonar-kotlin-plugin in cache, but this means that cache will be uploaded every time sonar-kotlin-plugin build number changes ie every PR, which is ~40 seconds to transfer ~1GB. To avoid this and if we wanna avoid downloading sonar-kotlin-plugin from Repox, then we can simply pass it from task that produces it into task that consumes it - see for example https://github.com/SonarSource/sonar-cpp/blob/6.65.0.81949/.cirrus.yml#L371-L381 and https://github.com/SonarSource/sonar-dart/blob/1.1.0.2133/.cirrus.yml#L175 |
@julien-carsique-sonarsource IMO this will also simplify script logic that you've been trying to debug. |
Signed-off-by: Jayadeep Kinavoor Madam <[email protected]>
dc8699e
to
f37e318
Compare
|
@Godin actually, I was fixing a Windows issue with interpreting the shell script.
That makes the cache efficient without the continuous update due to sonar-kotlin-plugin. The suggested improvement, from task to task, will also save the Repox bandwidth and totally makes sense. |
See #609 |
For the record part implemented here seems buggy https://cirrus-ci.com/task/6105864098021376?logs=cleanup_orchestrator_cache#L0
removed |
BUILD-7780
Part of https://sonarsource.atlassian.net/browse/BUILD-7780
This PR introduces caching of artifacts downloaded by orchestrator in the pipeline. It is necessary to reduce bandwidth consumption from repox.