Optimize parsing of PHP files #1427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreis2211
changed the title
Prior to this commit, PatternExpression is used inside the grammar for case-insensitive checks for e.g. keywords. This can be avoided by introducing a special CaseInsensitiveStringExpression that omits the relatively expensive regexes.
dreis2211
force-pushed
the
optimize-parser
branch
from
8ff1367 to
b6ee072
Compare
|
@GabinL21 let me know if you need anything from me (I'm assuming you review this based on your reaction). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when profiling a Sonar scan of a medium sized project I noticed that while parsing the PHP files a significant overhead is spent on doing regexes through
PatternExpression.This PR adds a special
CaseInsensitiveStringExpressionto achieve the same, but without regexes. To get all of its benefits, I also switched the values of some common words to lowercase as this matches the standard way how they would be written inside the code (and thus reducing the overhead even more).In local tests only doing parsing this cuts the portion of
PatternExpressionfrom ~21% to ~9%Before
After
The new
CaseInsensitiveStringExpressiononly accounts for ~2% of the samples, so quite an improvement to the previous state.In terms of time this also accounts roughly for a 13% reduction in my local tests.
Would appreciate if this is considered.
Cheers,
Christoph