SONARPY-1889 use a copy of ProjectLevelSymbolTable for v2 type inference

Author: maksim-grebeniuk-sonarsource

python-frontend/src/main/java/org/sonar/plugins/python/api/PythonVisitorContext.java

@@ -60,7 +60,7 @@ public PythonVisitorContext(FileInput rootTree, PythonFile pythonFile, @Nullable
 
     var symbolTable = new SymbolTableBuilderV2(rootTree)
       .build();
-    new TypeInferenceV2(new ProjectLevelTypeTable(projectLevelSymbolTable), pythonFile, symbolTable).inferTypes(rootTree);
+    new TypeInferenceV2(new ProjectLevelTypeTable(ProjectLevelSymbolTable.from(projectLevelSymbolTable)), pythonFile, symbolTable).inferTypes(rootTree);
   }
 
   public PythonVisitorContext(FileInput rootTree, PythonFile pythonFile, @Nullable File workingDirectory, String packageName,
@@ -71,7 +71,7 @@ public PythonVisitorContext(FileInput rootTree, PythonFile pythonFile, @Nullable
     new SymbolTableBuilder(packageName, pythonFile, projectLevelSymbolTable).visitFileInput(rootTree);
     var symbolTable = new SymbolTableBuilderV2(rootTree)
       .build();
-    new TypeInferenceV2(new ProjectLevelTypeTable(projectLevelSymbolTable), pythonFile, symbolTable).inferTypes(rootTree);
+    new TypeInferenceV2(new ProjectLevelTypeTable(ProjectLevelSymbolTable.from(projectLevelSymbolTable)), pythonFile, symbolTable).inferTypes(rootTree);
   }
 
   public PythonVisitorContext(PythonFile pythonFile, RecognitionException parsingException) {

python-frontend/src/main/java/org/sonar/python/semantic/ProjectLevelSymbolTable.java

@@ -24,6 +24,7 @@
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
+import java.util.Optional;
 import java.util.Set;
 import java.util.function.Function;
 import java.util.stream.Collectors;
@@ -60,6 +61,16 @@ public static ProjectLevelSymbolTable from(Map<String, Set<Symbol>> globalSymbol
     return new ProjectLevelSymbolTable(globalSymbolsByModuleName);
   }
 
+  public static ProjectLevelSymbolTable from(ProjectLevelSymbolTable from) {
+    var to = empty();
+    to.globalDescriptorsByModuleName.putAll(from.globalDescriptorsByModuleName);
+    Optional.ofNullable(from.globalDescriptorsByFQN)
+        .ifPresent(v -> to.globalDescriptorsByFQN = new HashMap<>(v));
+    to.djangoViewsFQN.addAll(from.djangoViewsFQN);
+    to.importsByModule.putAll(from.importsByModule);
+    return to;
+  }
+
   public ProjectLevelSymbolTable() {
     this.globalDescriptorsByModuleName = new HashMap<>();
   }