Merged
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
tomasz-tylenda-sonarsource
approved these changes
Jan 5, 2026
Contributor
tomasz-tylenda-sonarsource
left a comment
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
LGTM as is. Feel free to update the company name in this PR or separately.
Contributor
Author
|
As the project wasn't building, I fixed the java-version and aligned the JUnit Platerform version with the JUnit version used. The mapping can be found here. |
BartLucien
changed the title
dorian-burihabwa-sonarsource
approved these changes
Jan 7, 2026
Contributor
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
LGTM 👍🏿 Before merging, could you consolidate the work into 2 commits that can be rebased on master for merge:
- A commit with the fix of the Java version
- A commit with the year update in the license headers
The 2 commit messages should both start with the ticket number
Thanks!
BartLucien
force-pushed
the
lb/update-license-headers-2026
branch
2 times, most recently
from
3bce790 to
4f5de0b
Compare
The platform launcher version was not aligned with the JUnit version.
BartLucien
force-pushed
the
lb/update-license-headers-2026
branch
from
4f5de0b to
73a01b7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the build by updating the headers, the java version and aligning version in the JUnit framework.