Skip to content

SCANNPM-115 Fix release to not include dev packages#280

Merged
vdiez merged 2 commits intomasterfrom
fix-release
Sep 25, 2025
Merged

SCANNPM-115 Fix release to not include dev packages#280
vdiez merged 2 commits intomasterfrom
fix-release

Conversation

@vdiez
Copy link
Contributor

@vdiez vdiez commented Sep 25, 2025

Also lowered version of commander to ^13 as v14 requires node v20 and we still support Node 18

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fix release to not include dev packages SCANNPM-115 Fix release to not include dev packages Sep 25, 2025
@vdiez vdiez requested a review from zglicz September 25, 2025 09:32
@vdiez vdiez enabled auto-merge (squash) September 25, 2025 09:33
@sonarqubecloud
Copy link

🤖 Pull Request summary

Refactors dependency management and adds Node.js version logging to CI.

• Downgrades commander from v14.0.1 to v13.1.0 (reduces Node.js requirement from ≥20 to ≥18)
• Moves jest-sonar-reporter and replace-in-file from production to dev dependencies
• Adds Node.js version logging to CI setup script

Review focus: Verify the commander downgrade doesn't break any CLI functionality that relied on v14 features.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vdiez vdiez merged commit 34a80b3 into master Sep 25, 2025
8 of 9 checks passed
@vdiez vdiez deleted the fix-release branch September 25, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants