Skip to content

SCANNPM-117 Migrate scanner-npm to GHA#321

Merged
vdiez merged 19 commits intomasterfrom
cirrus-gh
Nov 6, 2025
Merged

SCANNPM-117 Migrate scanner-npm to GHA#321
vdiez merged 19 commits intomasterfrom
cirrus-gh

Conversation

@zglicz
Copy link
Contributor

@zglicz zglicz commented Nov 6, 2025

SCANNPM-117

Conflicts:

.cirrus.yml

Part of

# Conflicts:
#	.cirrus.yml
@zglicz zglicz requested a review from vdiez November 6, 2025 10:50
zglicz and others added 18 commits November 6, 2025 12:11
Separate nightly analysis jobs from main build workflow to improve clarity:
- build.yml now only runs SonarCloud analysis on every build
- nightly.yml runs all platform analyses (SonarCloud, NEXT, SQC-US) and IRIS sync on schedule

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
… steps

Replace the failing build-npm@v1 action with config-npm@v1 and manual npm commands for better control and to avoid template parsing issues.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Skip config-npm action and manually configure npm registry with vault credentials to avoid version field requirement.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Use correct vault path format with dashes instead of slashes: repository_owner-repository_name-private-reader

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Use correct vault path format for qa-deployer role

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Cache node_modules folder to avoid reinstalling dependencies in downstream jobs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Install dependencies in test/integration and tools/orchestrator before running tests

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Add cd .. commands to properly return to working directory after each step on Windows

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Remove shell: cmd specification to use PowerShell default
- Split commands for better error handling
- Use PowerShell's Copy-Item cmdlet
- Add npm install step before package installation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This ensures consistent line endings across Windows and Linux,
preventing prettier check-format failures on Windows runners.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
…jest

Using the full path with forward slashes doesn't work on Windows PowerShell.
Just using 'jest' works cross-platform as npm adds node_modules/.bin to PATH.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Use bash shell on Windows (matching Cirrus behavior) so both QA jobs
can use the same setup commands with subshells and forward slashes.
Remove redundant npm install step - only install the package directly.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Define qa-steps anchor once and reuse it for both qa-linux and qa-windows,
following the same pattern as Cirrus CI configuration.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Define steps anchor in qa-linux and reference it in qa-windows,
following GitHub Actions YAML anchor conventions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube Cloud

@zglicz zglicz marked this pull request as ready for review November 6, 2025 13:19
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@vdiez vdiez merged commit 637eebb into master Nov 6, 2025
8 checks passed
@vdiez vdiez deleted the cirrus-gh branch November 6, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants