SCANNPM-122 Avoid usage of "npm install" and use fix versions#353
Merged
SCANNPM-122 Avoid usage of "npm install" and use fix versions#353
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
jdkandersson
reviewed
Dec 1, 2025
SonarQube reviewer guideSummary: Consolidate Knip validation into main build step and add private npm registry configuration for integration tests. Review Focus: The addition of private Artifactory registry authentication and its usage during integration tests. Verify the secret retrieval and npm config steps properly secure credentials. The removal of the standalone Knip job should be validated against CI/CD requirements. Start review at:
|
jdkandersson
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.