Skip to content

SCANNPM-125 Fix build output structure by reverting tsx to 4.20.6#379

Merged
vdiez merged 2 commits intomasterfrom
fix/tsx-build-structure
Jan 7, 2026
Merged

SCANNPM-125 Fix build output structure by reverting tsx to 4.20.6#379
vdiez merged 2 commits intomasterfrom
fix/tsx-build-structure

Conversation

@zglicz
Copy link
Contributor

@zglicz zglicz commented Jan 7, 2026

Summary

  • Reverts tsx from 4.21.0 to 4.20.6 to fix broken build output structure
  • tsx 4.21.0 caused files to be placed flat in build/ instead of in build/bin/ and build/src/ subfolders
  • Adds validation step in release workflow to fail fast if expected folder structure is missing

Test plan

  • Verified build produces correct structure with tsx 4.20.6
  • CI passes

🤖 Generated with Claude Code

tsx 4.21.0 broke build output structure, causing files to be placed
flat in build/ instead of in build/bin/ and build/src/ subfolders.

Added validation step in release workflow to fail fast if the expected
folder structure is missing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fix build output structure by reverting tsx to 4.20.6 SCANNPM-125 Fix build output structure by reverting tsx to 4.20.6 Jan 7, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Jan 7, 2026

SCANNPM-125

@zglicz zglicz requested a review from vdiez January 7, 2026 14:20
@vdiez vdiez enabled auto-merge (squash) January 7, 2026 14:20
The knip upgrade in f291720 renamed bin/sonar-scanner.ts to .js which
broke the tsc output structure (files placed flat in build/ instead
of build/bin/ and build/src/).

This reverts the file rename and removes knip temporarily as it had
issues tracing the require() import.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vdiez vdiez merged commit 7a75b64 into master Jan 7, 2026
3 of 4 checks passed
@vdiez vdiez deleted the fix/tsx-build-structure branch January 7, 2026 14:30
zglicz added a commit that referenced this pull request Jan 7, 2026
Follow-up to #379 - knip was removed as a dependency but the CI
workflow still tried to run it.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
vdiez added a commit that referenced this pull request Jan 7, 2026
@vdiez vdiez mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants