SCANNPM-126 Remove knip from CI build workflow#380
Closed
Conversation
Follow-up to #379 - knip was removed as a dependency but the CI workflow still tried to run it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hashicorp-vault-sonar-prod
bot
changed the title
vdiez
approved these changes
Jan 7, 2026
SonarQube 2026.1 has a linkage error that prevents startup. Pin to the last known working version (25.12.0.117093) and allow override via SONARQUBE_VERSION env var. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Contributor
Author
|
Closing in favor of #381 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npx knipfrom the CI build workflow (follow-up to SCANNPM-125 Fix build output structure by reverting tsx to 4.20.6 #379 which removed knip as a dependency)25.12.0.117093in integration tests to avoid breakage from new SQ releases (2026.1 has a linkage error)SONARQUBE_VERSIONenv var override for flexibilityTest plan
🤖 Generated with Claude Code