Skip to content

SCANNPM-126 Remove knip from CI build workflow #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zglicz wants to merge 2 commits into from
Closed

SCANNPM-126 Remove knip from CI build workflow #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
521cd98
Remove knip from CI build workflow
zglicz Jan 7, 2026
e98be5a
Pin SonarQube version to 25.12.0.117093 for integration tests
zglicz Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ jobs:
- name: Build
run: |
npm run build
npx knip
env:
VERSION: SNAPSHOT

Expand Down
35 changes: 6 additions & 29 deletions tools/orchestrator/src/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,17 @@
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

import * as https from 'https';
import * as fs from 'fs';
import * as https from 'https';
import { execSync } from 'child_process';
import * as path from 'path';
import * as mkdirp from 'mkdirp';
import * as os from 'os';

const DEFAULT_VERSION = '9.7.1.62043';
// Pin SonarQube version to avoid breaking changes from new releases
// Can be overridden via SONARQUBE_VERSION env var
const PINNED_SONARQUBE_VERSION = process.env.SONARQUBE_VERSION || '25.12.0.117093';
const ARTIFACTORY_URL = process.env.ARTIFACTORY_URL || 'https://repox.jfrog.io';
const ARTIFACTORY_ACCESS_TOKEN = process.env.ARTIFACTORY_ACCESS_TOKEN;
const CACHE_PATH = path.join(os.homedir(), '.sonar');
Expand All @@ -51,36 +54,10 @@ export async function getLatestSonarQube(cacheFolder: string = DEFAULT_SONARQUBE
}

/**
* Returns the last available SonarQube Community edition version
*
* @param url the URL where to get the existing community SQ versions
* Returns the pinned SonarQube version (or from SONARQUBE_VERSION env var)
*/
function getLatestVersion(): Promise<string> {
const options = buildHttpOptions(
`/repox/api/search/versions?g=org.sonarsource.sonarqube&a=sonar-application&remote=0&repos=sonarsource-releases&v=*`,
);
return new Promise((resolve, reject) => {
https.get(options, response => {
let responseData = '';
response.on('data', data => {
responseData += data;
});
response.on('close', () => {
try {
const {
results: [{ version }],
} = JSON.parse(responseData);
resolve(version);
} catch (error) {
console.error('Error while parsing response', responseData);
reject(error);
}
});
response.on('error', error => {
reject(error);
});
});
});
return Promise.resolve(PINNED_SONARQUBE_VERSION);
}

/**
Expand Down
Loading