Skip to content

SCANPY-105 Deprecate the old PySonarScanner PyPI project #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

ghislainpiot
Copy link
Contributor

@ghislainpiot ghislainpiot commented Jun 11, 2025

@ghislainpiot
Copy link
Contributor Author

I thought about adding some text when running it, but not sure about the idea

@ghislainpiot
Copy link
Contributor Author

Releasing this might be a bit of a problem, I can't create a long-lived branch because commit ecae7ccdb873482bd5db49c047e208b4dcd36a8a is a merge commit and is rejected by the branch protection

@joke1196
Copy link
Contributor

This looks good, one thing also we need to do once this is released is to mark the project as Archived . I think I can personnally do it but it would be better to have sonar-tech do it. Also archival can be done in the future, there is no rush on that side.

@joke1196 joke1196 self-requested a review June 13, 2025 09:48
Copy link
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have added a small comment on the archival of the project on PiPy

@ghislainpiot
Copy link
Contributor Author

This looks good, one thing also we need to do once this is released is to mark the project as Archived . I think I can personnally do it but it would be better to have sonar-tech do it. Also archival can be done in the future, there is no rush on that side.

Good catch, not sure about the sonartech part. It might be faster to have you do it?

@joke1196
Copy link
Contributor

Definitely, once the release is done I will ask for approval and I will archive it.

@ghislainpiot ghislainpiot changed the base branch from gp/branch-0.3.0 to branch-0.3 June 16, 2025 10:14
@ghislainpiot ghislainpiot marked this pull request as ready for review June 16, 2025 10:14
Copy link

Copy link

Quality Gate passed Quality Gate passed for 'Python Scanner'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ghislainpiot ghislainpiot requested a review from joke1196 June 16, 2025 12:09
Copy link
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghislainpiot ghislainpiot merged commit 11f1bde into branch-0.3 Jun 16, 2025
13 checks passed
@ghislainpiot ghislainpiot deleted the SCANPY-105 branch June 16, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants