SCANPY-168 Limit size of output on wrong argument #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thomas-serre-sonarsource
approved these changes
Jun 13, 2025
| @@ -24,6 +24,14 @@ | |||
| from pysonar_scanner.exceptions import UnexpectedCliArgument | |||
|
|
|||
|
|
|||
| class PyScannerHelpFormatter(argparse.HelpFormatter): | |||
| recommended_args = {"help", "token", "sonar_project_key"} | |||
There was a problem hiding this comment.
nit It is minimal or mandatory args, not recommended args in my opinion
Suggested change
| recommended_args = {"help", "token", "sonar_project_key"} | |
| mandatory_args = {"help", "token", "sonar_project_key"} |
There was a problem hiding this comment.
Technically they are not mandatory, as I understand it will work for instance if them will be specified in toml file or env variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCANPY-168
Part of