Skip to content

SCANPY-190 Group command line arguments #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

maksim-grebeniuk-sonarsource
Copy link
Contributor

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource commented Jun 13, 2025

SCANPY-190

Part of

parser.add_argument(
"--sonar-links-homepage", "-Dsonar.links.homepage", type=str, help="The URL of the build project home page"
scanner_behavior_group.add_argument(
"-Dsonar.scm.forceReloadAll",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument looks weird in the help documentation

  -Dsonar.scm.forceReloadAll DSONAR.SCM.FORCERELOADALL
                        Equivalent to --sonar-scm-force-reload-all

this happens to all the ones with a getattr I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks true and this could be an idea for another ticket

"--sonar-scanner-java-exe-path",
"-Dsonar.scanner.javaExePath",

server_connection_group = parser.add_argument_group("SonarQube Server Connection")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
server_connection_group = parser.add_argument_group("SonarQube Server Connection")
server_connection_group = parser.add_argument_group("SonarQube Connection")

help="Python version used for the project",
)
parser.add_argument(
reports_group = parser.add_argument_group("3rd party report arguments")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reports_group = parser.add_argument_group("3rd party report arguments")
reports_group = parser.add_argument_group("3rd party reports arguments")

I think it needs the s

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource marked this pull request as ready for review June 13, 2025 13:51
Copy link
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this. And rebasing should make the CI succeed.

Copy link

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource merged commit 68b7420 into master Jun 16, 2025
15 checks passed
@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource deleted the SCANPY-190 branch June 16, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants