-
Notifications
You must be signed in to change notification settings - Fork 3
SCANPY-190 Group command line arguments #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
parser.add_argument( | ||
"--sonar-links-homepage", "-Dsonar.links.homepage", type=str, help="The URL of the build project home page" | ||
scanner_behavior_group.add_argument( | ||
"-Dsonar.scm.forceReloadAll", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This argument looks weird in the help documentation
-Dsonar.scm.forceReloadAll DSONAR.SCM.FORCERELOADALL
Equivalent to --sonar-scm-force-reload-all
this happens to all the ones with a getattr I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks true and this could be an idea for another ticket
"--sonar-scanner-java-exe-path", | ||
"-Dsonar.scanner.javaExePath", | ||
|
||
server_connection_group = parser.add_argument_group("SonarQube Server Connection") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server_connection_group = parser.add_argument_group("SonarQube Server Connection") | |
server_connection_group = parser.add_argument_group("SonarQube Connection") |
help="Python version used for the project", | ||
) | ||
parser.add_argument( | ||
reports_group = parser.add_argument_group("3rd party report arguments") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reports_group = parser.add_argument_group("3rd party report arguments") | |
reports_group = parser.add_argument_group("3rd party reports arguments") |
I think it needs the s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking care of this. And rebasing should make the CI succeed.
147391f
to
d640a8d
Compare
|
SCANPY-190
Part of