Skip to content

SCANPY-54: Running a scan displays a message to point the user to different Sonar product #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

SCANPY-54: Running a scan displays a message to point the user to different Sonar product #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/pysonar_scanner/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ def scan():

def do_scan():
app_logging.setup()
logging.info(
"Enhance your workflow: Pair pysonar with SonarQube Server per your license or SonarQube Cloud for deeper analysis, and try SonarQube-IDE in your favourite IDE."
)
logging.info("Starting Pysonar, the Sonar scanner CLI for Python")
config = ConfigurationLoader.load()
set_logging_options(config)
Expand Down
16 changes: 14 additions & 2 deletions tests/unit/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
import pathlib
from unittest.mock import patch, Mock
from unittest.mock import patch, Mock, call

from pyfakefs import fake_filesystem_unittest as pyfakefs

Expand All @@ -45,6 +45,7 @@

class TestMain(pyfakefs.TestCase):

@patch("pysonar_scanner.__main__.logging")
@patch.object(pathlib.Path, "home", return_value=pathlib.Path("home/user"))
@patch.object(
ConfigurationLoader,
Expand All @@ -61,7 +62,9 @@ class TestMain(pyfakefs.TestCase):
)
@patch("pysonar_scanner.__main__.create_jre", return_value=JREResolvedPath(pathlib.Path("jre_path")))
@patch.object(ScannerEngine, "run", return_value=0)
def test_minimal_success_run(self, run_mock, create_jre_mock, provision_mock, load_mock, path_home_mock):
def test_minimal_success_run(
self, run_mock, create_jre_mock, provision_mock, load_mock, path_home_mock, mock_logging
):
exitcode = scan()
self.assertEqual(exitcode, 0)

Expand All @@ -84,6 +87,15 @@ def test_minimal_success_run(self, run_mock, create_jre_mock, provision_mock, lo

self.assertEqual(expected_config, config)

info_logs = [
call(
"Enhance your workflow: Pair pysonar with SonarQube Server per your license or SonarQube Cloud for deeper analysis, and try SonarQube-IDE in your favourite IDE."
),
call("Starting Pysonar, the Sonar scanner CLI for Python"),
call("Starting the analysis..."),
]
mock_logging.info.assert_has_calls(info_logs)

@patch.object(ConfigurationLoader, "load")
def test_scan_with_exception(self, load_mock):
load_mock.side_effect = Exception("Test exception")
Expand Down