Skip to content

SCANPY-176 Avoid using POETRY_LINUX_TEMPLATE for Mend, formatting and documentation tasks #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

SCANPY-176 Avoid using POETRY_LINUX_TEMPLATE for Mend, formatting and documentation tasks #231

merged 1 commit into from
Jun 16, 2025

Conversation

ghislainpiot
Copy link
Contributor

@ghislainpiot ghislainpiot commented Jun 16, 2025 •
edited by jira bot
Loading

@ghislainpiot ghislainpiot force-pushed the SCANPY-176 branch 3 times, most recently from 4ee7b71 to 719654f Compare June 16, 2025 12:25
@ghislainpiot ghislainpiot changed the title SCANPY-176 First test SCANPY-176 Avoid using POETRY_LINUX_TEMPLATE for Mend, formatting and documentation tasks Jun 16, 2025
@ghislainpiot ghislainpiot marked this pull request as ready for review June 16, 2025 12:30
@ghislainpiot ghislainpiot requested a review from Seppli11 June 16, 2025 12:32
Seppli11
Seppli11 requested changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@Seppli11 Seppli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the script feels really complicated to me. To understand what the YAML for a task actually looks like, one has to keep a lot of references in mind. I wonder if the complexity could be reduced by consolidating different configs.

At least personally, I don't mind having a container with all the tools that are needed by most tasks, if that means that the config gets simpler. Of course, granted that it doesn't impact reliability or the time the built takes significantly.

@ghislainpiot ghislainpiot force-pushed the SCANPY-176 branch 2 times, most recently from 6172b46 to bdd2305 Compare June 16, 2025 14:48
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'Python Scanner'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ghislainpiot
Copy link
Contributor Author

Sending this for review again. I don't think spending too much time on this is worth it, we should think about dropping the ticket.
We will be moving to GHA soon anyways.

@ghislainpiot ghislainpiot requested a review from Seppli11 June 16, 2025 15:15
Seppli11
Seppli11 approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@Seppli11 Seppli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
This way feels a bit less tangled and easier to review. Thx for the refactoring

.cirrus.yml

win_vm_definition: &WINDOWS_VM_DEFINITION
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is smart. I like that the JF_ALIAS is now defined by the platform of the instance

@Seppli11 Seppli11 merged commit 0a47f10 into master Jun 16, 2025
17 checks passed
@Seppli11 Seppli11 deleted the SCANPY-176 branch June 16, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seppli11 Seppli11 Seppli11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghislainpiot @Seppli11