Skip to content

SCANPY-201 Enable analysis on both SQC instances #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

Conversation

Wohops
Copy link
Contributor

@Wohops Wohops commented Jun 20, 2025

Copy link

Copy link

@Wohops Wohops requested a review from ghislainpiot June 20, 2025 09:54
@Wohops
Copy link
Contributor Author

Wohops commented Jun 20, 2025

@ghislainpiot there are 3 commits:

  1. ca55bac is setting the "simplest" configuration I could think about. While running analysis on each PR so we can see it works. Above, you can see outcomes of the 3 instances reporting on the PR.
  2. 0d2847a is fixing a weird behavior when setting as host https://sonarqube.us (see ticket SCANPY-203)
  3. d07dd29 only runs the analysis to CRON and master branch

⚠️ Please keep the commits separated when merging and rebase.

Copy link
Contributor

@ghislainpiot ghislainpiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left very small comments, it is up to you to do the changes or not.

I have a bigger concern: if there is no issue synchronization, does that mean we might get Slack messages everyday?

@ghislainpiot ghislainpiot self-requested a review June 20, 2025 10:48
Copy link
Contributor

@ghislainpiot ghislainpiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had another look and I think it makes no sense to block, there is only one issue on the project and no hotspots

Copy link

Quality Gate passed Quality Gate passed for 'Python Scanner'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Wohops Wohops merged commit 775dbe8 into master Jun 23, 2025
15 checks passed
@Wohops Wohops deleted the mg/SCANPY-201 branch June 23, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants