Skip to content

SCANPY-202 Enable IRIS issue propagation to SQC-EU/US #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Conversation

Wohops
Copy link
Contributor

@Wohops Wohops commented Jun 24, 2025

@Wohops Wohops requested a review from ghislainpiot June 24, 2025 16:45
@Wohops
Copy link
Contributor Author

Wohops commented Jun 24, 2025

@ghislainpiot same comment as for PR https://github.com/SonarSource/sonar-python-enterprise/pull/330.
I added a commit that demonstrate that the dry run works. This commit should be dropped before merging if everything looks good to you.

Copy link
Contributor

@ghislainpiot ghislainpiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a tiny comment.

Comment on lines +318 to +319
depends_on:
- promote
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it needs to depend on promote itself, but not a big deal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want it to happen ideally after the daily scan, which is required to reach "promote". I feel its OK like this.

Copy link

Quality Gate passed Quality Gate passed for 'Python Scanner'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Wohops Wohops merged commit 335ac66 into master Jun 25, 2025
16 checks passed
@Wohops Wohops deleted the mg/SCANPY-202 branch June 25, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants