Skip to content

SCANPY-206 Fix tests on MacOS #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Conversation

thomas-serre-sonarsource
Copy link
Contributor

@thomas-serre-sonarsource thomas-serre-sonarsource commented Jul 7, 2025

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fix tests on MacOS SCANPY-206 Fix tests on MacOS Jul 7, 2025
@thomas-serre-sonarsource
Copy link
Contributor Author

@ghislainpiot What do you think about fixing the version of the macos image templates?

@ghislainpiot ghislainpiot requested a review from Seppli11 July 7, 2025 09:25
@ghislainpiot
Copy link
Contributor

@Seppli11 You were investigating this I think

@Seppli11
Copy link
Contributor

Seppli11 commented Jul 7, 2025

I haven't actually started investigating this yet.
There was an update to the macos container yesterday (see here), so there is a decent chance that this is related. I think it would be worth trying.

A note about the macos workers: There are only a limited number of workers available and they are only available during working hours. Because of this, there is an only_if clause for the macos build to restrict the tasks to run only once a day with a cron job. For debugging's sake, this only_if can be removed. It's possible that it takes quite a while for the job to start. If this is the case, the job mustn't be restarted as this puts additional strain on the infrastructure. What is most likely happening is that there is no free macos worker available.

So the macos task hasn't actually ran.

Copy link
Contributor

@Seppli11 Seppli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this issue.
I'm still a bit puzzled why changing the macOS version should make a test fail.

But for now, this will make master green again, so LGTM 😁 !

Copy link

sonarqube-next bot commented Jul 7, 2025

Quality Gate passed Quality Gate passed for 'Python Scanner'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@thomas-serre-sonarsource thomas-serre-sonarsource merged commit c858380 into master Jul 7, 2025
15 checks passed
@thomas-serre-sonarsource thomas-serre-sonarsource deleted the ts/fix-mac-ci branch July 7, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants