SCANPY-220 Migrate the mac os qa and its tasks #288
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
Seppli11
left a comment
Seppli11
left a comment
There was a problem hiding this comment.
Overall, the job looks good.
There are a few things missing for the macos runners to work without a problem (see the documentation here).
Also, it would be really nice if on failure a slack notification is sent.
Last but not least, I didn't find any runs of this workflow. Macos can be a fickle thing, so it would make sense to test.
But, the workflow as it is, looks promising and should work (I think...)
.github/workflows/MacOsNightly.yml
Outdated
| jobs: | ||
| qa-macos: | ||
| name: "Test macOS Python ${{ matrix.python-version }}" | ||
| runs-on: github-macos-large |
There was a problem hiding this comment.
according to the documentation, the label used for the macos runenrs is macos-latest-xlarge
| matrix: | ||
| python-version: ["3.9.18", "3.10.13", "3.11.7", "3.12.1", "3.13.2"] | ||
| steps: | ||
| - name: Checkout repository |
There was a problem hiding this comment.
The SonarSource/gh-action_setup-cloudflare-warp@v1 action is missing
| env: | ||
| SONARQUBE_VERSION: 25.3.0.104237 | ||
| steps: | ||
| - name: Checkout repository |
There was a problem hiding this comment.
same here, the SonarSource/gh-action_setup-cloudflare-warp@v1 action is missing
.github/workflows/MacOsNightly.yml
Outdated
| steps: | ||
| - name: Notify team about nightly failure | ||
| run: | | ||
| echo "macOS nightly build failed. Check the workflow run for details." |
There was a problem hiding this comment.
This should probably be outputted to a step summary.
Also, it would make sense if a slack message is sent in the #squad-python-notifs channel so we don't miss it
|
Also, it seems the jira automation created a new ticket, instead of latching on to SONARPY-220 |
marc-jasper-sonarsource
changed the title
…messages. Fixed race condition w.r.t. cache.
|
Seppli11
left a comment
Seppli11
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fixes. I've left one comment about the slack notification.
| echo "**Workflow Run:** ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" >> $GITHUB_STEP_SUMMARY | ||
| - name: Send Slack notification | ||
| uses: SonarSource/[email protected] |
There was a problem hiding this comment.
Going to the action's repository, it says that this is only suppose to be used for "legacy Cirrus CI notifications based on GitHub check suite events". They recommend using rtCamp/action-slack-notify
(It might also make sense to fail one run, to test this code path as well)
2 participants
No description provided.