Skip to content

delete unused python3.8 from black config #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
even-even wants to merge 2 commits into
base: master
Choose a base branch
from
Open

delete unused python3.8 from black config #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
143f6ea
delete unused python3.8 from black config
Jan 16, 2026
2015a65
delete unused python3.8 from black config
Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Run `poetry run pytest tests/its --its` to run the its.

To see the ITs in the VSCode test explorer, add the `--its` argument to the `python.testing.pytestArgs` setting in `.vscode/settings.json`.

The the following keys should be present:
The following keys should be present:
```json
"python.testing.unittestArgs": ["-v", "-s", "tests", "-p", "test_*.py"],
"python.testing.pytestEnabled": true,
Expand Down
18 changes: 16 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,21 @@ requires = ['poetry-core']

[project]
authors = [{ name="[Code Quality] Data & ML Squad", email="[email protected]" }]
classifiers = ['Environment :: Console', 'Intended Audience :: Developers', 'Operating System :: OS Independent', 'Programming Language :: Python', 'Programming Language :: Python :: 3', 'Programming Language :: Python :: 3 :: Only', 'Programming Language :: Python :: 3.9', 'Programming Language :: Python :: 3.10', 'Programming Language :: Python :: 3.11', 'Programming Language :: Python :: 3.12', 'Programming Language :: Python :: 3.13', 'Programming Language :: Python :: 3.14', 'Topic :: Software Development :: Quality Assurance']
classifiers = [
'Environment :: Console',
'Intended Audience :: Developers',
'Operating System :: OS Independent',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
'Programming Language :: Python :: 3.13',
'Programming Language :: Python :: 3.14',
'Topic :: Software Development :: Quality Assurance'
]
description = 'Sonar Scanner for the Python Ecosystem'
keywords = ['sonar', 'sonarqube', 'sonarcloud', 'cleancode']
license = 'LGPL-3.0-only'
Expand All @@ -20,7 +34,7 @@ repository = 'https://github.com/SonarSource/sonar-scanner-python'
[tool]
[tool.black]
line-length = 120
target-version = ['py38', 'py39', 'py310', 'py311', 'py312']
target-version = ['py39', 'py310', 'py311', 'py312', 'py313', 'py314']

[tool.coverage]
[tool.coverage.run]
Expand Down
10 changes: 6 additions & 4 deletions tests/unit/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,16 @@ def test_get_os(self):
def test_get_arch(self):
x64_machine_strs = ["amd64", "AmD64", "x86_64", "X86_64"]
for machine_str in x64_machine_strs:
with self.subTest("amd64", machine_str=machine_str), unittest.mock.patch(
"platform.machine", return_value=machine_str
with (
self.subTest("amd64", machine_str=machine_str),
unittest.mock.patch("platform.machine", return_value=machine_str),
):
self.assertEqual(get_arch(), Arch.X64)
arm_machine_strs = ["arm64", "ARm64"]
for machine_str in arm_machine_strs:
with self.subTest("arm", machine_str=machine_str), unittest.mock.patch(
"platform.machine", return_value=machine_str
with (
self.subTest("arm", machine_str=machine_str),
unittest.mock.patch("platform.machine", return_value=machine_str),
):
self.assertEqual(get_arch(), Arch.AARCH64)

Expand Down