SONARXML-216 Improve cache hits by removing BuildTime and fixing test order#328
Merged
leonardo-pilastri-sonarsource merged 2 commits intomasterfrom Jan 29, 2025
Merged
SONARXML-216 Improve cache hits by removing BuildTime and fixing test order#328leonardo-pilastri-sonarsource merged 2 commits intomasterfrom
leonardo-pilastri-sonarsource merged 2 commits intomasterfrom
Conversation
leonardo-pilastri-sonarsource
requested a review
from dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource
requested changes
Jan 28, 2025
Contributor
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
The plugin configuration looks good but I am not sure why the forbiddentapis plugin is part of the change
pom.xml
Outdated
Comment on lines
184
to
188
| <plugin> | ||
| <groupId>de.thetaphi</groupId> | ||
| <artifactId>forbiddenapis</artifactId> | ||
| <version>3.6</version> | ||
| </plugin> |
Contributor
There was a problem hiding this comment.
Is this plugin necessary?
Contributor
Author
There was a problem hiding this comment.
Whoops, probably a copy-paste leftover
|
dorian-burihabwa-sonarsource
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SONARXML-216