SONARXML-274 S3330 Detect missing httpOnlyCookies in web.config #372
Conversation
tomasz-tylenda-sonarsource
changed the title
tomasz-tylenda-sonarsource
force-pushed
the
tt/S3330-web-config
branch
from
a09355a to
ddc5cb9
Compare
tomasz-tylenda-sonarsource
changed the title
pavel-mikula-sonarsource
left a comment
pavel-mikula-sonarsource
left a comment
There was a problem hiding this comment.
What about the rspec?
...l-plugin/src/main/java/org/sonar/plugins/xml/checks/security/web/HttpOnlyOnCookiesCheck.java
Show resolved
Hide resolved
...ugin/src/test/java/org/sonar/plugins/xml/checks/security/web/HttpOnlyOnCookiesCheckTest.java
Show resolved
Hide resolved
...l-plugin/src/main/java/org/sonar/plugins/xml/checks/security/web/HttpOnlyOnCookiesCheck.java
Outdated
Show resolved
Hide resolved
...l-plugin/src/main/java/org/sonar/plugins/xml/checks/security/web/HttpOnlyOnCookiesCheck.java
Outdated
Show resolved
Hide resolved
...l-plugin/src/main/java/org/sonar/plugins/xml/checks/security/web/HttpOnlyOnCookiesCheck.java
Outdated
Show resolved
Hide resolved
...l-plugin/src/main/java/org/sonar/plugins/xml/checks/security/web/HttpOnlyOnCookiesCheck.java
Outdated
Show resolved
Hide resolved
I just sent out https://github.com/SonarSource/rspec/pull/5938. I wanted to go through the implementation first, in case we find something that would affect the RSpec. |
|
Thank you for the thorough first round! I have some questions, so I'm assigning it back. |
pavel-mikula-sonarsource
left a comment
pavel-mikula-sonarsource
left a comment
There was a problem hiding this comment.
LGTM, I'd like to see the ^^^^ somewhere
…curity/web/HttpOnlyOnCookiesCheck.java Clarify message Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
…curity/web/HttpOnlyOnCookiesCheck.java Formatting Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
tomasz-tylenda-sonarsource
force-pushed
the
tt/S3330-web-config
branch
from
72ba533 to
2d713e2
Compare
I added locations in test files. Given that this PR is needed for other work I will be merging it, but feel free to add comments and I will address them in the follow-up. I also added RSPEC files, so we do not have to create a separate PR to merge them. |
tomasz-tylenda-sonarsource
force-pushed
the
tt/S3330-web-config
branch
from
0156242 to
2d713e2
Compare
|
Still LGTM. I'm happy to see how the rule will behave |
|
2 participants
No description provided.