SLCORE-1550 Use ServerFixture for BindingSuggestionsMediumTests #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eray-felek-sonarsource
force-pushed
the
feautre/SLCORE-1550-utilize-serverfixture
branch
2 times, most recently
from
a250733 to
41132cd
Compare
eray-felek-sonarsource
force-pushed
the
feautre/SLCORE-1550-utilize-serverfixture
branch
from
41132cd to
78d522f
Compare
|
| @@ -359,6 +354,9 @@ void should_suggest_binding_by_remote_url_when_no_other_suggestions_found(SonarL | |||
| var scServer = harness.newFakeSonarCloudServer() | |||
| .withOrganization("orgKey", organization -> | |||
| organization.withProject(SLCORE_PROJECT_KEY, project -> project.withBranch("main"))) | |||
| .withDopTranslation(dop -> dop | |||
| .withProjectBinding(REMOTE_URL, PROJECT_ID, SLCORE_PROJECT_KEY) | |||
| .withSearchProjectsResponse("orgKey", PROJECT_ID, 200, "{\"components\":[{\"key\":\"" + SLCORE_PROJECT_KEY + "\",\"name\":\"" + SLCORE_PROJECT_NAME + "\"}]}\n")) | |||
There was a problem hiding this comment.
I would do this slightly differently. I think withDopTranslation and withProjectBinding are good, but I would remove withSearchProjectsResponse. Just above, there is already a call to organization.withProject, you could make sure this call registers a response to api/components/search_projects. You can also modify the project builder to add a withName. This would make the test even less verbose
medium-tests/src/test/java/mediumtest/BindingSuggestionsMediumTests.java
Show resolved
Hide resolved
| @@ -619,24 +552,16 @@ void should_return_empty_when_sqs_server_project_is_not_present(SonarLintTestHar | |||
|
|
|||
| var sqServer = harness.newFakeSonarQubeServer() | |||
| .withProject(SLCORE_PROJECT_KEY, project -> project.withBranch("main")) | |||
| .withDopTranslation(dop -> dop | |||
| .withProjectBinding(REMOTE_URL, PROJECT_ID, SLCORE_PROJECT_KEY) | |||
| .withComponentShowStatus(SLCORE_PROJECT_KEY, 404, "Project not found")) | |||
There was a problem hiding this comment.
Same here
nquinquenel
reviewed
Jul 25, 2025
test-utils/src/main/java/org/sonarsource/sonarlint/core/test/utils/server/ServerFixture.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-1550