Skip to content

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Aug 6, 2025

@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1531-gradle-2.x branch from 2abc338 to 809ac37 Compare August 8, 2025 14:15
@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1531-gradle-2.x branch from 0854bbe to 905432d Compare August 18, 2025 12:52
@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1531-gradle-2.x branch from 26a913c to 00df6c7 Compare August 18, 2025 13:47
@nquinquenel nquinquenel marked this pull request as ready for review August 18, 2025 13:47
Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the number of changes, I made a cursory review. I did not find any blocker, but getting another review from someone else might help. The only concern for me is raising the minimal supported version to a quite recent version, we should make sure this decision is OK with all stakeholders. You will also need to bump the major version and document it in the release notes.

One way to reduce the PR size could have been to bump the minimal supported version in one PR, and change the Gradle plugin in another, but it's always easier to say after the fact.

Finally, I want to give a huge kudos for following this topic for so long and finally bringing it to completion! It was not an easy one.

Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! As discussed I think we should also keep track of Windows improvements from IntelliJ platform with a ticket to check if they fixed the runIde issue where it takes too long to launch

Copy link

@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1531-gradle-2.x branch from a3e9166 to aa548fc Compare August 22, 2025 14:30
@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1531-gradle-2.x branch from 768f8fc to edcef4a Compare August 22, 2025 21:23
@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1531-gradle-2.x branch 3 times, most recently from ead4a80 to 3d923d6 Compare August 23, 2025 11:37
@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1531-gradle-2.x branch from 3d923d6 to ccc9add Compare August 23, 2025 11:45
Copy link

@nquinquenel nquinquenel merged commit 53abd54 into master Aug 23, 2025
30 checks passed
@nquinquenel nquinquenel deleted the feature/nq/SLI-1531-gradle-2.x branch August 23, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants