-
Notifications
You must be signed in to change notification settings - Fork 157
SLI-1531 Update to IntelliJ Platform Gradle Plugin (2.x) #1484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2abc338
to
809ac37
Compare
clion-common/src/test/java/org/sonarlint/intellij/clion/common/AnalyzerConfigurationTest.java
Show resolved
Hide resolved
0854bbe
to
905432d
Compare
26a913c
to
00df6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the number of changes, I made a cursory review. I did not find any blocker, but getting another review from someone else might help. The only concern for me is raising the minimal supported version to a quite recent version, we should make sure this decision is OK with all stakeholders. You will also need to bump the major version and document it in the release notes.
One way to reduce the PR size could have been to bump the minimal supported version in one PR, and change the Gradle plugin in another, but it's always easier to say after the fact.
Finally, I want to give a huge kudos for following this topic for so long and finally bringing it to completion! It was not an easy one.
src/main/java/org/sonarlint/intellij/ui/tree/SecurityHotspotTree.java
Outdated
Show resolved
Hide resolved
src/test/java/org/sonarlint/intellij/tasks/ConnectionTestTaskTests.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job! As discussed I think we should also keep track of Windows improvements from IntelliJ platform with a ticket to check if they fixed the runIde issue where it takes too long to launch
|
a3e9166
to
aa548fc
Compare
768f8fc
to
edcef4a
Compare
ead4a80
to
3d923d6
Compare
3d923d6
to
ccc9add
Compare
|
SLI-1531