Skip to content

SLVS-2465 Add analysis engine to connect with Roslyn APIs #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: feature/sqvs-roslyn-plugin
Choose a base branch
from

Conversation

georgii-borovinskikh-sonarsource
Copy link
Contributor

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented Aug 8, 2025

SLVS-2465

Part of

Copy link

sonarqubecloud bot commented Aug 8, 2025

🤖 Pull Request summary

Updates baseline files and adds comprehensive unit tests for Roslyn analyzer engine.

Main Changes:
• Updates assembly reference baseline files with additional dependencies (Microsoft.CodeAnalysis, Microsoft.VisualStudio.LanguageServices, etc.)
• Adds 276-line unit test file for SequentialSonarRoslynAnalysisEngineTests with comprehensive test coverage
• Includes MEF export verification, singleton pattern validation, and analysis workflow testing
• Updates project dependencies and configurations to support the new testing infrastructure

Key Areas for Review:

  • The test coverage appears thorough but verify the mock setup accurately reflects real Roslyn analyzer behavior
  • Assembly baseline changes show significant dependency additions - ensure these don't introduce version conflicts
  • Test methods using complex mock chains should be validated for correctness of the underlying analysis workflow

💬 Please send your feedback

Quality Gate Failed Quality Gate failed

Failed conditions
15 New issues
32.6% Coverage on New Code (required ≥ 85%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant