Partition select #15
Open
Partition select #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking on the Disk Usage tile will show a dialog to select the partition. Still some kinks though.
Separate the runnable to load the usage into a standalone class. Use this to force a usage update immediately after selecting a partition. Also, don't stop the running task.
Maintain the selected partition in a SharedPreference in order to keep it persistently.
Move the creation of the dialog and managing of preference into MainActivity as it make more sense within the Android design paradigm. Needed to add a callback for when the available partitions are loaded.
Member
|
Sorry @mseabold - I did not see this PR come in. |
Author
|
I did realize that when I save the selected partition to the preferences, I don't key it off of which session selected the partition. So when you select a partition, it persists that selection across all juice connections. I'll probably look into correcting that. |
|
This is a Longshot but is there any hope for this |
|
I would also love this, but guessing it was not useful to the maintainer. This is a huge feature add-on I would love to have in a very awesome plugin. My root partion is pretty static, my /home is always more important to me |
Slamology2
approved these changes
Aug 22, 2017
|
Continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to change the partition used for Disk Usage by clicking on the tile
I'm definitely open to any suggestions or corrections.
Addresses #13