Skip to content

Restructure tests directory hierarchy (pytest)#1378

Merged
irenaby merged 3 commits intomainfrom
tests
Mar 10, 2025
Merged

Restructure tests directory hierarchy (pytest)#1378
irenaby merged 3 commits intomainfrom
tests

Conversation

@irenaby
Copy link
Copy Markdown
Contributor

@irenaby irenaby commented Mar 9, 2025

Pull Request Description:

Restructure pytest directory into two levels: first level is framework/common, second level is unit/integration.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby requested a review from ofirgo March 10, 2025 06:30
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need "common" inside "common_tests/unit_tests"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed



class KerasFwMixin:
""" Mixin helper class containing keras-specific definitions. """
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's Mixin?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A design patter that provides specific functionality via class. It's not used in this PR but you can do
class MyTest(MaybeSomeOtherClass, KerasFwMixin) and get the functionality. The purpose of inheritance here is just to inject functionality.

@irenaby irenaby merged commit 7bd8f49 into main Mar 10, 2025
42 checks passed
@ofirgo ofirgo deleted the tests branch July 2, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants