Adding weights manual selection bitwidth#1379

Merged

kawakami-masaki0 merged 38 commits intoSonySemiconductorSolutions:mainfrom

gouda-youichi:adding_weights_manual_selection_bitwidth

Mar 26, 2025

Contributor

gouda-youichi commented Mar 10, 2025

Pull Request Description:

Adding weights manual selection bitwidth.

Checklist before requesting a review:

I set the appropriate labels on the pull request.
I have added/updated the release note draft (if necessary).
I have updated the documentation to reflect my changes (if necessary).
All function and files are well documented.
All function and classes have type hints.
There is a licenses in all file.
The function and variable names are informative.
I have checked for code duplications.
I have added new unittest (if necessary).

gouda-youichi and others added 19 commits

January 28, 2025 17:02


          pytorch_activation_threshold_search(Debugging and exploration code re…

a81fd1e

…mains)


          Merge branch 'sony:main' into main

4c66805


          pytorch_activation_threshold_search(refine a little)

66a3bd9


          Merge branch 'main' of https://github.com/gouda-youichi/model_optimiz…

ffe0e6d

…ation into main


          Fixed ofirgo-san's review comment.

746cb57


          Fixed ofirgo-san's review comment.[2]


          Fixed ofirgo-san's review comment.[3]

67b78b5


          PR comment correction (in progress)

722380b


          [DEBUG]about printout layer_type


          PR comment correction(fixed)

d5481a0


          Merge branch 'sony:main' into main

2f6e5fc


          Merge branch 'main' of https://github.com/gouda-youichi/model_optimiz…

947f56c

…ation into main


          Merge branch 'main' of https://github.com/gouda-youichi/model_optimiz…

…ation into main


          add set_manual_weights_bit_width to bit_width_config.py

7d4ba38


          modified get_nodes_to_manipulate_bit_widths and etc

6eec34b


          All implementations completed. Not yet tested.

6c3c262


          Merge branch 'sony:main' into adding_weights_manual_selection_bitwidth

50af865


          revert original setting for tpc.


          add test for weights_manual_selection_bitwidth

b283c81

github-actions bot added the auto:core label


          modified test_manual_weights_bitwidth_selection.py

a776f4c

ofirgo suggested changes

View reviewed changes

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/target_platform_capabilities/tpc_models/imx500_tpc/v1/tpc.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

gouda-youichi added 8 commits

March 12, 2025 10:24


          revert tpc.py

424dde6


          correcting accrding to the feedback comments

b07fc5d


          correcting according to the feedback comments

02dce0c


          correcting according to the feedback comments.

464f1da


          Revert unnecessary modifications

bc0cf98


          Revert set_node_quantization_config.py

70db8e8


          fixing for manual weights selection bitwidth(kernel,bias)

c51a200


          fixing for manual weights selection bitwidth(kernel,bias)

37d2dcf

ofirgo suggested changes

View reviewed changes

model_compression_toolkit/core/common/quantization/bit_width_config.py Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

gouda-youichi added 2 commits

March 14, 2025 13:47


          fixed PR-FB for manual weights selection bitwidth

d411b8d


          rename test script

5b88fe2

ofirgo suggested changes

View reviewed changes

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

gouda-youichi added 3 commits

March 19, 2025 16:28


          Correcting comments on pull requests

1f30c99


          Correcting comments on pull requests_2

8ee3002


          Fixed comments on pull requests.

2a3c40c

ofirgo suggested changes

View reviewed changes

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

tests_pytest/common_tests/core/common/quantization/test_manual_weights_bitwidth_selection.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

kawakami-masaki0 added 4 commits

March 24, 2025 17:23


          Merge branch 'sony:main' into adding_weights_manual_selection_bitwidth

1af4e11


          fixing for manual weights selection bitwidth

7ba5a17


          add __init__.py

afe57b4


          fix imported module

c49ba74

ofirgo suggested changes

View reviewed changes

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved

model_compression_toolkit/core/common/quantization/bit_width_config.py Outdated Show resolved Hide resolved


          fixed to check for integer or string

e7737d6

ofirgo approved these changes

View reviewed changes

kawakami-masaki0 merged commit 9e6a4dc into SonySemiconductorSolutions:main

34 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels