Simplify MP manager - LP solver candidates representation, add MP, LP unit tests and MP e2e tests#1403
Conversation
added 10 commits
April 6, 2025 11:32
… LPSolver and the API between them
irenaby
commented
Apr 6, 2025
model_compression_toolkit/core/common/mixed_precision/mixed_precision_search_manager.py
Show resolved
Hide resolved
irenaby
commented
Apr 6, 2025
model_compression_toolkit/core/common/mixed_precision/search_methods/linear_programming.py
Show resolved
Hide resolved
ofirgo
suggested changes
Apr 10, 2025
Contributor
ofirgo
left a comment
ofirgo
left a comment
There was a problem hiding this comment.
I still need to go over the tests, but left some comments and questions for now
model_compression_toolkit/core/common/quantization/node_quantization_config.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/common/mixed_precision/search_methods/linear_programming.py
Show resolved
Hide resolved
model_compression_toolkit/core/common/mixed_precision/mixed_precision_search_facade.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/common/mixed_precision/mixed_precision_search_manager.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/keras/back2framework/mixed_precision_model_builder.py
Show resolved
Hide resolved
ofirgo
reviewed
Apr 16, 2025
ofirgo
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Fix find_min/max_candidate graph's method.
Simplify data representation in LP solver.
Convert configurations list in topological order to explicit dict from node to index where convenient.
Add unit tests for LP Solver
Add unit tests for MPSearchManager
Add E2E tests for mixed precision search, via ptq api, for torch.
Checklist before requesting a review: