Skip to content

Add OpQuantizationConfig to schema v2 of Fusing class#1414

Merged
kkawa14 merged 7 commits intoSonySemiconductorSolutions:mainfrom
kkawa14:add_fuse_op_quant_config_to_schema_v2
Apr 22, 2025
Merged

Add OpQuantizationConfig to schema v2 of Fusing class#1414
kkawa14 merged 7 commits intoSonySemiconductorSolutions:mainfrom
kkawa14:add_fuse_op_quant_config_to_schema_v2

Conversation

@kkawa14
Copy link
Copy Markdown
Contributor

@kkawa14 kkawa14 commented Apr 15, 2025

Pull Request Description:

Adding fuse_op_quantization_config field to schema v2 of Fusing class
Adding unittests for Fusing class with schema v2

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo requested a review from lior-dikstein April 15, 2025 07:39
Logger.critical("Fusing cannot be created for a single operator.") # pragma: no cover

# Check instance of fuse_op_quantization_config.
if model.fuse_op_quantization_config is not None:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to check this? Doesn't Pydantic handle type validation automatically?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't fully understand the details of type validation in Pydantic.
I've confirmed that validation was working correctly with Pydantic, I removed the unnecessary validation code section.

@kkawa14 kkawa14 merged commit 8d99193 into SonySemiconductorSolutions:main Apr 22, 2025
28 checks passed
@kkawa14 kkawa14 deleted the add_fuse_op_quant_config_to_schema_v2 branch May 23, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants