Add OpQuantizationConfig to schema v2 of Fusing class#1414
Merged
kkawa14 merged 7 commits intoSonySemiconductorSolutions:mainfrom Apr 22, 2025
Merged
Conversation
| Logger.critical("Fusing cannot be created for a single operator.") # pragma: no cover | ||
|
|
||
| # Check instance of fuse_op_quantization_config. | ||
| if model.fuse_op_quantization_config is not None: |
Contributor
There was a problem hiding this comment.
Why is it necessary to check this? Doesn't Pydantic handle type validation automatically?
Contributor
Author
There was a problem hiding this comment.
I couldn't fully understand the details of type validation in Pydantic.
I've confirmed that validation was working correctly with Pydantic, I removed the unnecessary validation code section.
lior-dikstein
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Adding fuse_op_quantization_config field to schema v2 of Fusing class
Adding unittests for Fusing class with schema v2
Checklist before requesting a review: