Add tests for quantization preserving handling in resource_utilization_calculator tests.#1417
Merged
Add tests for quantization preserving handling in resource_utilization_calculator tests.#1417
Conversation
…n_calculator tests.
irenaby
suggested changes
Apr 16, 2025
...ests/core/mixed_precision/resource_utilization_tools/test_resource_utilization_calculator.py
Outdated
Show resolved
Hide resolved
irenaby
reviewed
Apr 20, 2025
tests_pytest/conftest.py
Outdated
| """ Basic Graph mock. """ | ||
| return Mock(spec_set=Graph, nodes=[], retrieve_preserved_quantization_node=lambda x: x) | ||
| return Mock(spec_set=Graph, nodes=[], | ||
| retrieve_preserved_quantization_node=lambda x: None if x.is_quantization_preserving() else x) |
Contributor
There was a problem hiding this comment.
Why should it be here and why should it return None? Why not patch it in relevant tests with relevant values?
irenaby
approved these changes
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Add tests for quantization preserving handling in resource_utilization_calculator tests.
Checklist before requesting a review: