Merged
Conversation
added 2 commits
April 15, 2025 14:46
added 2 commits
April 15, 2025 16:06
elad-c
reviewed
Apr 16, 2025
Contributor
elad-c
left a comment
There was a problem hiding this comment.
Add unittest and e2e test
model_compression_toolkit/core/pytorch/back2framework/pytorch_model_builder.py
Show resolved
Hide resolved
model_compression_toolkit/core/pytorch/back2framework/pytorch_model_builder.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/pytorch/back2framework/pytorch_model_builder.py
Outdated
Show resolved
Hide resolved
elad-c
reviewed
Apr 22, 2025
tests_pytest/pytorch_tests/integration_tests/core/back2framework/test_weights_reuse.py
Outdated
Show resolved
Hide resolved
tests_pytest/pytorch_tests/integration_tests/core/back2framework/test_weights_reuse.py
Show resolved
Hide resolved
tests_pytest/pytorch_tests/integration_tests/core/back2framework/test_weights_reuse.py
Show resolved
Hide resolved
elad-c
approved these changes
Apr 24, 2025
elad-c
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Const reuse bug description:
When initiating a reused node using another "original" node, the original node might not be initialized yet in case there is no hierarchy between the nodes.
Bugfix description:
First initialized all none-reused nodes, than do a second pass over reused nodes. This way we assure the "original" node was initiated before the reused node
Checklist before requesting a review: