Skip to content

Constant Reuse#1418

Merged
yarden-yagil-sony merged 9 commits intomainfrom
bugfix/const_reuse
Apr 25, 2025
Merged

Constant Reuse#1418
yarden-yagil-sony merged 9 commits intomainfrom
bugfix/const_reuse

Conversation

@yarden-yagil-sony
Copy link
Copy Markdown
Contributor

Pull Request Description:

Const reuse bug description:
When initiating a reused node using another "original" node, the original node might not be initialized yet in case there is no hierarchy between the nodes.

Bugfix description:
First initialized all none-reused nodes, than do a second pass over reused nodes. This way we assure the "original" node was initiated before the reused node

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@yarden-yagil-sony yarden-yagil-sony marked this pull request as draft April 15, 2025 11:57
@ofirgo ofirgo requested a review from elad-c April 15, 2025 13:01
@yarden-yagil-sony yarden-yagil-sony marked this pull request as ready for review April 15, 2025 13:02
@yarden-yagil-sony yarden-yagil-sony removed the request for review from elad-c April 15, 2025 13:02
Copy link
Copy Markdown
Contributor

@elad-c elad-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unittest and e2e test

@yarden-yagil-sony yarden-yagil-sony merged commit e70c359 into main Apr 25, 2025
31 checks passed
@ofirgo ofirgo deleted the bugfix/const_reuse branch July 2, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants