Node Supported Bitwidth Filtering Bugfix#1422
Merged
yarden-yagil-sony merged 8 commits intomainfrom Apr 24, 2025
Merged
Conversation
Contributor
|
Can you please explain what was the bug here? |
| for qc_opts in next_nodes_qc_options | ||
| for op_cfg in qc_opts.quantization_configurations]) | ||
| for op_cfg in qc_opts.quantization_configurations | ||
| if op_cfg.enable_activation_quantization or op_cfg.quantization_preserving |
Contributor
Author
There was a problem hiding this comment.
@ofirgo
here the "if" condition was missing, which led to considering cq of nodes with enable_activation_quantization=False and quantization_preserving=False.
It leds to error when these irrelevant nodes support only 8 and not both 8 and 16 bit, resulting in a node manually set to bithwidth16 but support only 8 bit (since we take the minimum of preserving next nodes supported bitwidth, line 131).
elad-c
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Filter out nodes without enable quantization and not preserving
Checklist before requesting a review: