Apply activation quantization parameters selection#1466
Closed
gouda-youichi wants to merge 0 commit intoSonySemiconductorSolutions:mainfrom
Closed
Apply activation quantization parameters selection#1466gouda-youichi wants to merge 0 commit intoSonySemiconductorSolutions:mainfrom
gouda-youichi wants to merge 0 commit intoSonySemiconductorSolutions:mainfrom
Conversation
kkawa14
changed the title
ofirgo
reviewed
Jun 12, 2025
| attr_cfg.set_weights_quantization_param(weights_params) | ||
|
|
||
| if n.is_activation_quantization_enabled(): | ||
| if n.is_activation_quantization_enabled() or n.is_fln_quantization(): |
Contributor
There was a problem hiding this comment.
The condition here should be based on the fusing info, not the node candidate mode, similarly to the fix from PR #1462
The same should apply for the condition in set_activation_quantization_param (the other change in this PR).
ofirgo
reviewed
Jun 17, 2025
|
|
||
| """ | ||
| assert self.quant_mode == ActivationQuantizationMode.QUANT | ||
| assert self.quant_mode == ActivationQuantizationMode.QUANT or self.quant_mode == ActivationQuantizationMode.FLN_QUANT |
Contributor
There was a problem hiding this comment.
this assertion needs to be modified to check for node is_enable_activation_quantization and same for fln quantization (similarly to all other places that this check occurs)
gouda-youichi
added a commit
to kkawa14/model_optimization
that referenced
this pull request
Jun 30, 2025
gouda-youichi
force-pushed
the
apply_actq_params_selection_for_node_inside_fln
branch
from
1f477f8 to
14516ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply activation quantization parameters selection for Stage3-4.
Pull Request Description:
Checklist before requesting a review: