Skip to content

Remove quantization functions from node quantization configs#1477

Merged
irenaby merged 6 commits intomainfrom
qpreparation3
Jun 30, 2025
Merged

Remove quantization functions from node quantization configs#1477
irenaby merged 6 commits intomainfrom
qpreparation3

Conversation

@irenaby
Copy link
Copy Markdown
Contributor

@irenaby irenaby commented Jun 25, 2025

Pull Request Description:

Remove {activation, weights}_quantization_fn and {activation, weights}_quantization_params_fn from NodeActivationQuantizationConfig and WeightsAttrQuantizationConfig respectively. Now the configs only contain the quantization method enum value.
Clean-up the API for fetching the functions and computing quantization params.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby changed the base branch from main to qpreparation2 June 25, 2025 15:15
@irenaby irenaby changed the base branch from qpreparation2 to main June 30, 2025 06:00
@irenaby irenaby marked this pull request as ready for review June 30, 2025 07:23
@irenaby irenaby requested a review from ofirgo June 30, 2025 07:23
@irenaby irenaby merged commit 06d4589 into main Jun 30, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants