Remove QuantizationConfig fields patch from NodeActivationQuantizationConfig#1480
Merged
Remove QuantizationConfig fields patch from NodeActivationQuantizationConfig#1480
Conversation
902157a to
a35916c
Compare
a1acf0b to
ec87fa1
Compare
added 5 commits
July 6, 2025 09:13
…ut_scaling, concat_threshold_update from NodeActivationQuantizationConfig
…culation} from NodeActivationQuantizationConfig
…rainable activation quantizer config
yarden-yagil-sony
approved these changes
Jul 6, 2025
Contributor
yarden-yagil-sony
left a comment
There was a problem hiding this comment.
Approved with 2 minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Remove the intermediate patch that injected fields from QuantizationConfig back to NodeActivationQuantizationConfig.
Use QuantizationConfig directly in all places that read it from the node candidates.
Remove min_threshold from TrainableQuantizerActivationConfig.
Checklist before requesting a review: