Skip to content

Remove QuantizationConfig fields patch from NodeActivationQuantizationConfig#1480

Merged
irenaby merged 5 commits intomainfrom
acfg_cleanup
Jul 6, 2025
Merged

Remove QuantizationConfig fields patch from NodeActivationQuantizationConfig#1480
irenaby merged 5 commits intomainfrom
acfg_cleanup

Conversation

@irenaby
Copy link
Copy Markdown
Contributor

@irenaby irenaby commented Jun 30, 2025

Pull Request Description:

Remove the intermediate patch that injected fields from QuantizationConfig back to NodeActivationQuantizationConfig.
Use QuantizationConfig directly in all places that read it from the node candidates.
Remove min_threshold from TrainableQuantizerActivationConfig.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby force-pushed the acfg_cleanup branch 2 times, most recently from 902157a to a35916c Compare July 1, 2025 09:22
@irenaby irenaby changed the title Acfg cleanup Remove QuantizationConfig fields patch from NodeActivationQuantizationConfig Jul 1, 2025
@irenaby irenaby marked this pull request as ready for review July 1, 2025 10:01
@irenaby irenaby requested a review from ofirgo July 1, 2025 10:01
@ofirgo ofirgo requested review from yarden-yagil-sony and removed request for ofirgo July 1, 2025 11:06
@irenaby irenaby force-pushed the acfg_cleanup branch 2 times, most recently from a1acf0b to ec87fa1 Compare July 1, 2025 16:16
Copy link
Copy Markdown
Contributor

@yarden-yagil-sony yarden-yagil-sony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 2 minor comments

@irenaby irenaby merged commit 3be1c7b into main Jul 6, 2025
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants