Conversation
elad-c
approved these changes
Jul 2, 2025
added 6 commits
July 6, 2025 13:29
…Config and trainable weights quantizer config
…rom NodeWeightsQuantizationConfig
elad-c
approved these changes
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Breaking change: removed min_threshold from QuantizationConfig.
Remove the temporary patch that injected fields previously read from QuantizationConfig back into NodeWeightsQuantizationConfig and WeightsAttrQuantizationConfig.
Pass QuantizationConfig or its relevant field(s) instead of getting it from the node.
Second moment correction: for now keep weights_second_moment_correction flag in NodeWeightsQuantizationConfig, as it is used to mark the nodes for which to apply the correction and remove the reconstructed BN, but instead of reading from QuantizationConfig, set it in BN reconstruction substitution.
Bias correction: remove weights_bias_correction flag from NodeWeightsQuantizationConfig. bias_corrected field is still injected into the config, use it instead to determine whether bias correction should be applied.
Checklist before requesting a review: