Skip to content

Remove default output axis values from fw_info.#1489

Merged
elad-c merged 5 commits intomainfrom
remove_default_output_axis_from_fw_info
Jul 6, 2025
Merged

Remove default output axis values from fw_info.#1489
elad-c merged 5 commits intomainfrom
remove_default_output_axis_from_fw_info

Conversation

@elad-c
Copy link
Copy Markdown
Contributor

@elad-c elad-c commented Jul 2, 2025

Pull Request Description:

Remove default output axis values from fw_info.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@reuvenperetz
Copy link
Copy Markdown
Contributor

We will need to take care of pruning. It relies on the output channel axis to compute what percentage of each layer to remove (since the SIMD is included in this computation). Perhaps we can set a default and verify that the model architecture does not break this assumption in the pruning facade. If so, we can raise an error.

@reuvenperetz reuvenperetz self-requested a review July 2, 2025 14:48
elad-c added 4 commits July 3, 2025 09:41
1. Collectors for nodes that don't have a known output channel axis, collect for the whole tensor.
2. Pruning retain defaults that are now defined in the PruningImplementation.
@elad-c elad-c merged commit 47bf2dd into main Jul 6, 2025
31 checks passed
@elad-c elad-c deleted the remove_default_output_axis_from_fw_info branch July 6, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants