Remove default output axis values from fw_info.#1489
Merged
Conversation
reuvenperetz
approved these changes
Jul 2, 2025
Contributor
|
We will need to take care of pruning. It relies on the output channel axis to compute what percentage of each layer to remove (since the SIMD is included in this computation). Perhaps we can set a default and verify that the model architecture does not break this assumption in the pruning facade. If so, we can raise an error. |
1. Collectors for nodes that don't have a known output channel axis, collect for the whole tensor. 2. Pruning retain defaults that are now defined in the PruningImplementation.
…_axis_from_fw_info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Remove default output axis values from fw_info.
Checklist before requesting a review: