restore an ability to set z-threshold per node using network editor#1491
Merged
restore an ability to set z-threshold per node using network editor#1491
Conversation
ofirgo
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
z_threshold attribute has been previously removed from NodeActivationQuantizationConfig along with other attrs coming from QuantizationConfig. However we do want the ability to override it per node (currently via network editor). This PR adds z_threshold attribute back to NodeActivationQuantizationConfig with default value None. In activation qparams computation zthreshold is taken from QuantizationConfig unless the node config has a non-None value.
Checklist before requesting a review: