Skip to content

restore an ability to set z-threshold per node using network editor#1491

Merged
irenaby merged 1 commit intomainfrom
editor_fix
Jul 7, 2025
Merged

restore an ability to set z-threshold per node using network editor#1491
irenaby merged 1 commit intomainfrom
editor_fix

Conversation

@irenaby
Copy link
Copy Markdown
Contributor

@irenaby irenaby commented Jul 7, 2025

Pull Request Description:

z_threshold attribute has been previously removed from NodeActivationQuantizationConfig along with other attrs coming from QuantizationConfig. However we do want the ability to override it per node (currently via network editor). This PR adds z_threshold attribute back to NodeActivationQuantizationConfig with default value None. In activation qparams computation zthreshold is taken from QuantizationConfig unless the node config has a non-None value.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby marked this pull request as ready for review July 7, 2025 09:51
@irenaby irenaby requested a review from ofirgo July 7, 2025 09:51
@irenaby irenaby merged commit 3fdc043 into main Jul 7, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants