Skip to content

[SSS Review] Develop XQuant Extension Tool#1502

Merged
ueno-hiroshi002 merged 2 commits intotmp_newmainfrom
feature_v2.4.3.dev1
Sep 24, 2025
Merged

[SSS Review] Develop XQuant Extension Tool#1502
ueno-hiroshi002 merged 2 commits intotmp_newmainfrom
feature_v2.4.3.dev1

Conversation

@ueno-hiroshi002
Copy link
Copy Markdown
Collaborator

@ueno-hiroshi002 ueno-hiroshi002 commented Sep 18, 2025

Pull Request Description:

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

yt0705 and others added 2 commits September 17, 2025 08:43
* Developed the XQuant Extension Tool.
* Developed XQuant to support "not Tensor"(not only "list") input.
* Updated repository URLs in documents and tutorials.
Copy link
Copy Markdown

@YingYang-YY YingYang-YY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the fix for #1503 ?

For now python_requires='>=3.6', however, if not using Python >= 3.9, there is error:
"ImportError: cannot import name 'Annotated' from 'typing'"
However, there is request to support Python >= 3.8. Is it possible to support Python >= 3.8 and fix #1503 ?

@YingYang-YY
Copy link
Copy Markdown

Could you also add the fix for #1503 ?
The above request will be supported in another PR.

@YingYang-YY YingYang-YY self-requested a review September 24, 2025 00:59
@ueno-hiroshi002 ueno-hiroshi002 merged commit 7a5fe9b into tmp_newmain Sep 24, 2025
32 checks passed
@ueno-hiroshi002 ueno-hiroshi002 deleted the feature_v2.4.3.dev1 branch September 24, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants