Skip to content

[SSS Review] feature_log_onoff#143

Merged
KazunoriSumiya merged 1 commit intomainfrom
feature_log_onoff
Dec 25, 2025
Merged

[SSS Review] feature_log_onoff#143
KazunoriSumiya merged 1 commit intomainfrom
feature_log_onoff

Conversation

@KazunoriSumiya
Copy link
Collaborator

@KazunoriSumiya KazunoriSumiya commented Dec 24, 2025

Pull Request Description:

Copy modify logger.py from mct and modify LOGGER_NAME.
Removed the process of calling the set_log_folder function of mctq from mct.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Copy modify logger.py from mct and modify LOGGER_NAME.
Removed the process of calling the set_log_folder function of mctq from mct.
@KazunoriSumiya KazunoriSumiya marked this pull request as ready for review December 25, 2025 00:41
@ueno-hiroshi002 ueno-hiroshi002 changed the title feature_log_onoff (#141) [SSS Review] feature_log_onoff Dec 25, 2025
@KazunoriSumiya KazunoriSumiya merged commit 0c66d5c into main Dec 25, 2025
23 checks passed
@yt0705 yt0705 deleted the feature_log_onoff branch December 25, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants