Lots of optimizations by forestrf · Pull Request #1 · SophieH/Sinput

Commits on Nov 18, 2018

Removed some garbage generation by caching some System.Enum.Parse results
forestrf
committed
Some optimizations + if GetKey is false, GetKeyDown will always also be false (added tests to verify it)
forestrf
committed
Some micro optimizations
forestrf
committed
Simplified signature of several functions + removed unusued comments of some functions
forestrf
committed
Small code reduction. Not an optimization
forestrf
committed
Reused array and changed a ToUpper with a string.Equals that ignores Case
forestrf
committed
connectedGamepads is always equal to _gamepads.Length. Changed connectedGamepads to a property to prevent external modifications
forestrf
committed
Used [RuntimeInitializeOnLoadMethod] to initialize SInput automagically
forestrf
committed
Merged two variables to a property of type { get; private set; }
forestrf
committed
SInput.cs is not inside a namespace, generating conflicts with other classes that have the same name as those inside SinputSystems. Removed `using SinputSystems;` and manually added `SinputSystems.…
forestrf
committed
Removed static temp variables that are not needed + cached some calls to Enum.GetValues
forestrf
committed
Changed strings comparisons with int comparisons by pre hasing strings and comparing hashes. The case of two control names having the same hash is nearly impossible
forestrf
committed
Cached String.Format for axis
forestrf
committed
Small changes
forestrf
committed
PrefersDeltaUse speedup by calculating inside Control/SmartControl during SInput.SinputUpdate();
forestrf
committed
Optimizations: Button states uses less logic code, and removed button checks from ShootyPlayer when checking it doesn't matter
forestrf
committed
Small optimizations
forestrf
committed
Small changes (for => foreach)
forestrf
committed

Commits on Nov 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lots of optimizations#1

Lots of optimizations#1
forestrf wants to merge 24 commits intoSophieH:masterfrom
forestrf:master

Commits on Nov 18, 2018

Removed some garbage generation by caching some System.Enum.Parse results

Some optimizations + if GetKey is false, GetKeyDown will always also be false (added tests to verify it)

Some micro optimizations

Simplified signature of several functions + removed unusued comments of some functions

Small code reduction. Not an optimization

Reused array and changed a ToUpper with a string.Equals that ignores Case

connectedGamepads is always equal to _gamepads.Length. Changed connectedGamepads to a property to prevent external modifications

Used [RuntimeInitializeOnLoadMethod] to initialize SInput automagically

Merged two variables to a property of type { get; private set; }

SInput.cs is not inside a namespace, generating conflicts with other classes that have the same name as those inside SinputSystems. Removed `using SinputSystems;` and manually added `SinputSystems.…

Removed static temp variables that are not needed + cached some calls to Enum.GetValues

Changed strings comparisons with int comparisons by pre hasing strings and comparing hashes. The case of two control names having the same hash is nearly impossible

Cached String.Format for axis

Small changes

PrefersDeltaUse speedup by calculating inside Control/SmartControl during SInput.SinputUpdate();

Optimizations: Button states uses less logic code, and removed button checks from ShootyPlayer when checking it doesn't matter

Small optimizations

Small changes (for => foreach)

Commits on Nov 19, 2018

Bug fix (gamepad 7 tested two times, gamepad 8 not tested)

Reused cached array 2 more times

Optimization: Removed extra button state check by reusing the AxisCheck

Commits on Nov 20, 2018

Initialization allowed manually. Unity initializes it automatically thanks to the attribute, but it is useful to be able to initialize it manually too

Commits on Nov 21, 2018

Micro optimization and removed casting

Commits on Dec 6, 2018

Fix input index instead of a gamead slot.