Skip to content

Conversation

@citizen-stig
Copy link
Member

@citizen-stig citizen-stig commented Jan 29, 2026

Description

And other outdated comments.

  • I have updated CHANGELOG.md with a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.
  • I have carefully reviewed all my Cargo.toml changes before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)

Testing

All existing tests are passing

Docs

No updates

@citizen-stig citizen-stig marked this pull request as ready for review January 29, 2026 10:57
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

This PR fixes a configuration field naming inconsistency in MockDa config files and adds validation to prevent similar issues in the future.

Key changes:

  • Corrected finalization to finalization_blocks in two config files
  • Added #[serde(deny_unknown_fields)] to MockDaConfig struct to catch typos at deserialization time
  • Added additionalProperties: false to the JSON schema for stricter validation
  • Updated outdated comment in Celestia config about default timeout value
  • Added new commented configuration options for reference

The change is backward-incompatible for configs using the incorrect finalization field name, but this prevents silent misconfigurations where the field was being ignored.

Confidence Score: 5/5

  • This PR is safe to merge with no issues found
  • All changes are straightforward corrections fixing naming inconsistencies and adding proper validation. The stricter validation is a positive change that will catch configuration errors earlier.
  • No files require special attention

Important Files Changed

Filename Overview
crates/adapters/mock-da/src/config.rs added deny_unknown_fields to prevent misconfigurations
examples/demo-rollup/configs/mock_rollup_config.toml fixed finalization to finalization_blocks, added new commented config options
typescript/examples/soak-testing/templates/rollup.toml corrected finalization to finalization_blocks

@citizen-stig citizen-stig merged commit b129ddf into dev Jan 29, 2026
26 checks passed
@citizen-stig citizen-stig deleted the nikolai/fix-mock-rollup-config-example branch January 29, 2026 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants